Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:cascader): reposition cascader when column opens #2836

Merged
merged 2 commits into from
Feb 13, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 24, 2019

close #2181, #2809

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e409863

https://deploy-preview-2836--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #2836 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
+ Coverage   95.53%   95.53%   +<.01%     
==========================================
  Files         517      517              
  Lines       12264    12276      +12     
  Branches     1692     1693       +1     
==========================================
+ Hits        11716    11728      +12     
  Misses        189      189              
  Partials      359      359
Impacted Files Coverage Δ
components/cascader/nz-cascader.component.ts 96.01% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6dfbd9...571c72e. Read the comment docs.

@netlify
Copy link

netlify bot commented Jan 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 571c72e

https://deploy-preview-2836--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 289ba54 into NG-ZORRO:master Feb 13, 2019
@wzhudev wzhudev deleted the cascader-position branch February 18, 2019 01:12
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…O#2836)

* feat(module:cascader): reposition cascader when column opens

close NG-ZORRO#2181, close NG-ZORRO#2809

* fix: typo
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…O#2836)

* feat(module:cascader): reposition cascader when column opens

close NG-ZORRO#2181, close NG-ZORRO#2809

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cascader 控件选项列表超出屏幕时无法正确选择
2 participants